Date: Wed, 16 Dec 2009 10:09:40 +0000 From: Baptiste Daroussin <baptiste.daroussin@gmail.com> To: freebsd-ports@freebsd.org Subject: Re: New version of the fakeroot patch Message-ID: <ed7b1c610912160209u420064ccwae1dc493685d4fbc@mail.gmail.com> In-Reply-To: <a01628140912160149r3eb6dd6ax7015897116076bdf@mail.gmail.com> References: <20091214151318.GC1016@wicklow.lan> <a01628140912160149r3eb6dd6ax7015897116076bdf@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> I don't know if this should be a port setting. I think this should be
> a user setting. So, I think WITH_FAKE / WITH_FAKEROOT is a better
> choice. Obviously ports not working with fakeroot would have to define
> something like IGNORE_FAKEROOT, the same kind of variable we have for
> MAKE_JOBS.
>
I note this and will make the modifications to do that. (next patch
should be next year)
>
> I'm thinking files could be moved from the fakeroot directory instead
> of copied, that way you could run 'find ${FAKEDIR} ! -type d' and find
> out if you've missed anything.
>
I have to think about this, but yes that could be the right thing to do.
>
> On pointyhat, a package will be generated at the end regardless. Also,
> quite a lot of tools do make a package backup before deinstalling, so
> I don't see this as a major issue. If people don't like the I/O
> overhead, we could use pkg_add in slave mode, it will skip the package
> building phase.
>
I agree with that
>
> As I mentioned it before, I think it's a very valuable feature to have.
>
> --
> Florent Thoumie
> flz@FreeBSD.org
> FreeBSD Committer
>
Thanks for your feedback, I'll send a new version of the patch soon.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed7b1c610912160209u420064ccwae1dc493685d4fbc>