Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Feb 2019 21:20:46 +0000
From:      bugzilla-noreply@freebsd.org
To:        x11@FreeBSD.org
Subject:   [Bug 235886] [patch] x11-clocks/xclock: update to 1.0.8; add missing dependencies and LICENSE
Message-ID:  <bug-235886-7141-pxSpaA2gbW@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-235886-7141@https.bugs.freebsd.org/bugzilla/>
References:  <bug-235886-7141@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235886

--- Comment #7 from Samy Mahmoudi <samy.mahmoudi@gmail.com> ---
(In reply to Niclas Zeising from comment #6)

I just had a look at bsd.port.mk and bsd.xorg.mk.

We could stay to:

XORG_CAT=3D       app
USES=3D           iconv
USE_XORG=3D       xrender xft xkbfile xt xaw

or we could go for:

USES=3D           iconv
XORG_CAT=3D       app
USE_XORG=3D       xrender xft xkbfile xt xaw

or even:

XORG_CAT=3D       app

USES=3D           iconv
USE_XORG=3D       xrender xft xkbfile xt xaw

These blocks would have the same effect: XORG_CAT only needs to be before
USE_XORG, as you suggested. But which style do you prefer (in case we submit
patches for portlint and the handbook) ?

IMHO, we should mention XORG_CAT directly before USE_XORG (second alternati=
ve)
to avoid duplication of Xorg-related variables, as in:

XORG_CAT=3D       app
USES=3D           iconv
USE_SOMETHING=3D
USE_SOMETHING=3D
USE_SOMETHING=3D
USE_SOMETHING=3D
USE_SOMETHING=3D
USE_XORG=3D       xrender xft xkbfile xt xaw

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235886-7141-pxSpaA2gbW>