Date: Thu, 15 Nov 2018 20:08:37 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: Devin Hussey <husseydevin@gmail.com>, freebsd-questions@freebsd.org Subject: Re: Question about porting sh tests to dash. Message-ID: <57acbcc0-50cf-827a-f7e3-edbfd50d42d5@yuripv.net> In-Reply-To: <CAEtFKstGyg_an_6ECOy6--1C7k3n97BVULj=HKvniKK1HC%2BNVA@mail.gmail.com> References: <CAEtFKstGyg_an_6ECOy6--1C7k3n97BVULj=HKvniKK1HC%2BNVA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WU89KU4QuPihVugTjq8m4ePcFxqzShJik Content-Type: multipart/mixed; boundary="ytlny5Og1580IpD3dvrx3r6KYW1kjtxkN"; protected-headers="v1" From: Yuri Pankov <yuripv@yuripv.net> To: Devin Hussey <husseydevin@gmail.com>, freebsd-questions@freebsd.org Message-ID: <57acbcc0-50cf-827a-f7e3-edbfd50d42d5@yuripv.net> Subject: Re: Question about porting sh tests to dash. References: <CAEtFKstGyg_an_6ECOy6--1C7k3n97BVULj=HKvniKK1HC+NVA@mail.gmail.com> In-Reply-To: <CAEtFKstGyg_an_6ECOy6--1C7k3n97BVULj=HKvniKK1HC+NVA@mail.gmail.com> --ytlny5Og1580IpD3dvrx3r6KYW1kjtxkN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Devin Hussey wrote: > The dash shell has a complete lack of quality control. It has a total > of zero tests, which is a problem considering it is supposed to be the > reliable workhorse /bin/sh on many Linux distros. >=20 > For example, I have seen a patch that was so buggy that dash couldn't > even run its own ./configure script. Despite this, two versions were > released without it even being noticed. Recently, it happened again: > Another patch was released which broke variable expansion, five other > patches pushed, a supposed "fix" for the buggy patch, that didn't even > fix the most obvious bug. >=20 > dash, like FreeBSD's sh, is based off of ash, and therefore would be > compatible with most or all of the FreeBSD tests. >=20 > I was considering porting some or all of the sh test suite to dash > (obviously giving credit), as the tests are remarkably thorough. I > want to know if you are all okay with it. There's no need to ask, the license text describes all you can (or can not) do. It would be nice though if you could give back any useful changes/fixes. > Obviously, some tweaks would be required, such as how the tests are > run. However, it would still save weeks, if not months of repetitive > work and would prevent/fix many serious bugs in the codebase. Or you could just use kyua/atf the tests are using, and save yourself even more time :-) --ytlny5Og1580IpD3dvrx3r6KYW1kjtxkN-- --WU89KU4QuPihVugTjq8m4ePcFxqzShJik Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlvtqB4ACgkQk4vgf7Eq 4WxMDQf9ELjvs/qnK9GLB0E2TlNSdjb8jCXUcViMQzadNgVxzbrjgEV5vVU78/i4 m1QqLlPUcd9en2Mxii5NmwEonBehPysEOYJBTspF8dug+TsGT8bGPrDjEPA8EjQS PUVaVY4lsDuvRG+AQ2R4mBBHnbHzyKMAH6s9ycCZd74Xh6HrMAV8nVP75gCpCwt5 S3dzKPdQEjfxBUHystcM5D7VTrlz8MQDKYp1ej7OZVjRR2NK06tx/7CdWlIIA/Tj Bd8LTjw9FyKow09shhtx9+u14xhAH3+UI+byh+lPt8usIsWGIwOaNv5nRmu0cG1I V5+sObnwlUoEOdzup0YMLr8EeU+STw== =SvVq -----END PGP SIGNATURE----- --WU89KU4QuPihVugTjq8m4ePcFxqzShJik--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57acbcc0-50cf-827a-f7e3-edbfd50d42d5>