Date: Tue, 18 Sep 2012 16:30:56 +0100 From: Attilio Rao <attilio@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Davide Italiano <davide@freebsd.org>, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>, Jeff Roberson <jeff@freebsd.org>, Dimitry Andric <dim@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r238907 - projects/calloutng/sys/kern Message-ID: <CAJ-FndAXw6zjXr=zB3gAVQDKUV_K4=SF39iYQQOV23NkfJ=MPw@mail.gmail.com> In-Reply-To: <20120918083324.GX37286@deviant.kiev.zoral.com.ua> References: <201207301350.q6UDobCI099069@svn.freebsd.org> <CAJ-FndBj8tpC_BJXs_RH8sG2TBG8yA=Lxu3-GTVT9Ap_zOCuVQ@mail.gmail.com> <CAJ-FndDnO7wjnWPV0tTu%2BUGHjsxa3YDarMxmyei3ZmjLAFvRkQ@mail.gmail.com> <201207301732.33474.jhb@freebsd.org> <CAJ-FndD5EO12xsWOAe6u0EvX00q33wxO4OivnGjzj0=T2Oe8uA@mail.gmail.com> <CAJ-FndCRg0UCThFkatp=tw7rUWWCvhsApLE=iztLpxpGBC1F9w@mail.gmail.com> <20120918083324.GX37286@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/18/12, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Tue, Sep 18, 2012 at 01:13:08AM +0100, Attilio Rao wrote:
>> diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h
>> index 8224672..fc6a75f 100644
>> --- a/sys/sys/cdefs.h
>> +++ b/sys/sys/cdefs.h
>> @@ -114,6 +114,13 @@
>> #endif
>>
>> /*
>> + * Compiler memory barriers, specific to gcc and clang.
>> + */
>> +#if defined(__GNUC__)
>> +#define __compiler_membar() __asm __volatile(" " : : :
>> "memory")
>> +#endif
>> +
>> +/*
>
> Traditionally, we do provide the fallback for non-GNUC compilers, by
> defining extern function with the compatible signature. In this case,
> the empty function just works for the purpose, although with higher
> overhead than the GNUC case.
I agree, we need a fallback here. Unfortunately I'm buried with job
stuff but I will provide an errata patch ASAP.
Thanks,
Attilio
--
Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndAXw6zjXr=zB3gAVQDKUV_K4=SF39iYQQOV23NkfJ=MPw>