Date: Thu, 9 Jan 2020 15:31:47 -0800 From: Mark Millard <marklmi@yahoo.com> To: Leandro Lupori <leandro.lupori@gmail.com> Cc: Justin Hibbits <chmeeedalf@gmail.com>, FreeBSD PowerPC ML <freebsd-ppc@freebsd.org>, "bdragon@freebsd.org" <bdragon@freebsd.org> Subject: Re: A possible unbounded loop in moea_sync_icache: why sys/vm/mlock_test:mlock__copy_on_write_vnode fails? Message-ID: <DE7F8044-B159-4E9E-88C2-54987F5ECF39@yahoo.com> In-Reply-To: <CAC7XEcJgXZMBb1q8TrqERWwWHLq9g=NNC0hiG7ZAH7kvASYK1g@mail.gmail.com> References: <022334D3-B60E-440F-A514-8D8002B65CB4.ref@yahoo.com> <022334D3-B60E-440F-A514-8D8002B65CB4@yahoo.com> <CAC7XEcJgXZMBb1q8TrqERWwWHLq9g=NNC0hiG7ZAH7kvASYK1g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-Jan-9, at 03:12, Leandro Lupori <leandro.lupori at gmail.com> = wrote: > Interesting, this looks like the same issue that was fixed on 64-bit = some time ago: https://reviews.freebsd.org/D19149. I changed my local code to use va+1 as in that update and can confirm that I now get: # kyua test -k /usr/tests/Kyuafile sys/vm/mlock_test sys/vm/mlock_test:mlock__copy_on_write_anon -> passed [0.018s] sys/vm/mlock_test:mlock__copy_on_write_vnode -> passed [0.008s] sys/vm/mlock_test:mlock__truncate_and_resize -> passed [0.019s] sys/vm/mlock_test:mlock__truncate_and_unlock -> passed [0.019s] > On Thu, Jan 9, 2020 at 3:03 AM Mark Millard via freebsd-ppc = <freebsd-ppc at freebsd.org> wrote: >> . . . >> The code in question: >>=20 >> static void >> moea_sync_icache(mmu_t mmu, pmap_t pm, vm_offset_t va, vm_size_t sz) >> { =20 >> struct pvo_entry *pvo; >> vm_offset_t lim; >> vm_paddr_t pa; >> vm_size_t len; >>=20 >> PMAP_LOCK(pm); >> while (sz > 0) { >> lim =3D round_page(va); The above line is where I changed the va to be va+1 . >> len =3D MIN(lim - va, sz); >> pvo =3D moea_pvo_find_va(pm, va & ~ADDR_POFF, NULL); >> if (pvo !=3D NULL) { >> pa =3D (pvo->pvo_pte.pte.pte_lo & PTE_RPGN) | >> (va & ADDR_POFF); >> moea_syncicache(pa, len); >> } >> va +=3D len; >> sz -=3D len; >> } >> PMAP_UNLOCK(pm); >> } >=20 =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DE7F8044-B159-4E9E-88C2-54987F5ECF39>