Date: Thu, 22 Oct 2009 14:17:29 +0000 From: "b. f." <bf1783@googlemail.com> To: "Li, Qing" <qing.li@bluecoat.com> Cc: freebsd-current@freebsd.org Subject: Re: svn commit: r198306 - head/sys/net Message-ID: <d873d5be0910220717pf5cdb44q45651660fe32ec9@mail.gmail.com> In-Reply-To: <B583FBF374231F4A89607B4D08578A4305AE9207@bcs-mail03.internal.cacheflow.com> References: <d873d5be0910201621h768e126dq34df38c07b83fe47@mail.gmail.com> <bc2d970910201734o332582ceic30fb7e42e14c812@mail.gmail.com> <d873d5be0910201900w67833e83kf53b556e2b5c8d00@mail.gmail.com> <bc2d970910202030u2c03571etb6379cf29260617d@mail.gmail.com> <9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com> <B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com> <d873d5be0910212016qea39846v45a3ddd21ee45d55@mail.gmail.com> <B583FBF374231F4A89607B4D08578A4305AE9207@bcs-mail03.internal.cacheflow.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/22/09, Li, Qing <qing.li@bluecoat.com> wrote: >> >> Perhaps not strictly necessary, but wouldn't it be better to have it? >> What is your rationale for not using making it conditional on SMP? >> > > If the definition itself is not within the preprocessor command, what > is the benefit of having it in the code ? > Do you mean what is the benefit of including the preprocessor commands? Well, in that case, because there is less unnecessary code to compile and traverse. If you mean to ask why sys/sys/smp.h was included unconditionally, to use smp_started and mp_maxid when they don't need to be used in the case of non-SMP kernels, then I'm guessing that the original author didn't really care all that much about efficiency in the non-SMP case, or at least that a unified treatment of SMP and non-SMP was more appealing to him, and I agree that further improvements could be made. b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d873d5be0910220717pf5cdb44q45651660fe32ec9>