Date: Tue, 09 Jun 2009 10:07:43 +0300 From: Danny Braniss <danny@cs.huji.ac.il> To: rea-fbsd@codelabs.ru Cc: d@delphij.net, current@freebsd.org, net@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sparc64 Message-ID: <E1MDvQt-000CEr-B0@kabab.cs.huji.ac.il> In-Reply-To: <pnDviOUhM/SNuybQq0u/UHsbVeU@j4OYE6OL8eALCd4BvSxIfwgoxSc> References: <20090608224516.547F17302F@freebsd-current.sentex.ca> <4A2DA390.3090704@delphij.net> <pnDviOUhM/SNuybQq0u/UHsbVeU@j4OYE6OL8eALCd4BvSxIfwgoxSc>
next in thread | previous in thread | raw e-mail | index | archive | help
> Xin, good day. > > Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: > > The attached patch should fix this, any objections? > > Yes, you missed negation operator in the copyin check. The issue > was already fixed by hrs@ two hours ago: > http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 sorry to barge in, but: if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) is not clear, if ((options & ~GIF_FULLOPTS) == 0) seems to be less offuscated or I'm missing something? danny > -- > Eygene > _ ___ _.--. # > \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard > / ' ` , __.--' # to read the on-line manual > )/' _/ \ `-_, / # while single-stepping the kernel. > `-'" `"\_ ,_.-;_.-\_ ', fsc/as # > _.-'_./ {_.' ; / # -- FreeBSD Developers handbook > {_.-``-' {_/ # > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1MDvQt-000CEr-B0>