Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Jun 2008 08:55:26 +0200
From:      Jeremie Le Hen <jeremie@le-hen.org>
To:        FreeBSD Tinderbox <tinderbox@freebsd.org>
Cc:        current@freebsd.org, i386@freebsd.org
Subject:   Re: [head tinderbox] failure on i386/i386
Message-ID:  <20080626065526.GE15815@obiwan.tataz.chchile.org>
In-Reply-To: <20080626062043.19D1073039@freebsd-current.sentex.ca>
References:  <20080626062043.19D1073039@freebsd-current.sentex.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

On Thu, Jun 26, 2008 at 02:20:43AM -0400, FreeBSD Tinderbox wrote:
> vga_isa.o(.text+0x1f7): In function `isavga_probe':
> : undefined reference to `__stack_chk_fail'
> xboxfb.o(.text+0xa79): In function `xboxfb_diag':
> : undefined reference to `__stack_chk_guard'
> xboxfb.o(.text+0xb03): In function `xboxfb_diag':
> : undefined reference to `__stack_chk_guard'
> xboxfb.o(.text+0xb0a): In function `xboxfb_diag':
> : undefined reference to `__stack_chk_fail'
> *** Error code 1

This is my bad, sorry.  Please apply the following patch:

Index: sys/kern/stack_protector.c
===================================================================
RCS file: /mnt/octobre/space/freebsd-cvs/src/sys/kern/stack_protector.c,v
retrieving revision 1.1
diff -u -r1.1 stack_protector.c
--- sys/kern/stack_protector.c  25 Jun 2008 21:33:28 -0000      1.1
+++ sys/kern/stack_protector.c  26 Jun 2008 06:57:11 -0000
@@ -7,7 +7,6 @@
 #include <sys/systm.h>
 #include <sys/libkern.h>
 
-#if defined(__SSP__) || defined(__SSP_ALL__)
 long __stack_chk_guard[8] = {};
 void __stack_chk_fail(void);
 
@@ -31,5 +30,3 @@
 }
 /* SI_SUB_EVENTHANDLER is right after SI_SUB_LOCK used by arc4rand() init. */
 SYSINIT(stack_chk, SI_SUB_EVENTHANDLER, SI_ORDER_ANY, __stack_chk_init, NULL);
-
-#endif

-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080626065526.GE15815>