Date: Mon, 17 Feb 2003 22:18:31 -0800 From: Peter Wemm <peter@wemm.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include pci_cfgreg.h src/sys/i386/pci pci_bus.c pci_cfgreg.c src/sys/kern subr_witness.c Message-ID: <20030218061831.B82A32A89E@canning.wemm.org> In-Reply-To: <200302180336.h1I3aneM052083@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Wemm wrote: > peter 2003/02/17 19:36:49 PST > > Modified files: > sys/i386/include pci_cfgreg.h > sys/i386/pci pci_bus.c pci_cfgreg.c > sys/kern subr_witness.c > Log: > Initiate de-orbit burn for USE_PCI_BIOS_FOR_READ_WRITE. This has been > #if'ed out for a while. Complete the deed and tidy up some other bits. > > We need to be able to call this stuff from outer edges of interrupt > handlers for devices that have the ISR bits in pci config space. Making > the bios code mpsafe was just too hairy. We had also stubbed it out some > time ago due to there simply being too much brokenness in too many systems. > This adds a leaf lock so that it is safe to use pci_read_config() and > pci_write_config() from interrupt handlers. We still will use pcibios > to do interrupt routing if there is no acpi.. [yes, I tested this] Incidently, did anybody know that it is utterly unsafe to use pci_read_config() or pci_write_config() in interrupt handlers on RELENG_4? And yes, lots of drivers do it a lot! :-( Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030218061831.B82A32A89E>