Date: Sat, 10 Mar 2018 16:48:05 -0700 From: Ian Lepore <ian@freebsd.org> To: Pete French <petefrench@ingresso.co.uk>, freebsd-stable@freebsd.org Subject: Re: zfs problems after rebuilding system [SOLVED] Message-ID: <1520725685.84937.144.camel@freebsd.org> In-Reply-To: <217437b9-9879-8919-966a-45cf5eb58d33@ingresso.co.uk> References: <21c64a2d-b9f9-24c8-88ec-ff1210891f60@zyxst.net> <CAOtMX2gHm_UdYzn5J6Lm76r8KakkYMzEcxddFYLqkmGYwkihuQ@mail.gmail.com> <65372449-53f1-8002-981a-e20f4a592e26@zyxst.net> <CAOtMX2g79aqkinu0meBzhLbui7n9H9yiEwxKm6cxpZSaxbWqbg@mail.gmail.com> <f0e9385c-4d62-a68d-ea93-f013bc456b5d@zyxst.net> <CAOjFWZ4Yq4cnWN_qucbN4W-6qtf4NYNzjNKe4QL17DU-Q=N%2B_g@mail.gmail.com> <CAOjFWZ53WaOtCvRtNpsL1OqgE7rDu8jWNEHRVPZ5Z3Q_n1bnqw@mail.gmail.com> <CAOjFWZ6gF3=N8=v3aXQaiG=pd8kmZ-xpvN2jHYj9%2Bh8fCm=rsw@mail.gmail.com> <CAOjFWZ7nPFdKr_G2qHihXdcHUBed7V0uLLHM9=p1PKzJMZNemw@mail.gmail.com> <CAOjFWZ6J7UV_xXxtASqnonS8qatqaSSEqJUKyi9nw%2Bms%2BUg1QQ@mail.gmail.com> <5CFC89E9-57BE-4CB7-9C55-0D3CCF1E8D3D@FreeBSD.org> <edfb5da8-3fad-168f-4dbc-6da9b0822c76@zyxst.net> <20180303234236.M3811@besplex.bde.org> <9b3cd942-347c-44a2-60d6-0b3c4a45552f@ingresso.co.uk> <1520723109.84937.136.camel@freebsd.org> <84146241-12d3-8333-0687-c2377838f175@ingresso.co.uk> <1520723722.84937.139.camel@freebsd.org> <217437b9-9879-8919-966a-45cf5eb58d33@ingresso.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2018-03-10 at 23:42 +0000, Pete French wrote: > > > > It looks like r330745 applies fine to stable-11 without any changes, > > and there's plenty of value in testing that as well, if you're already > > set up for that world. > > > > Ive been running the patch from the PR in production since the original > bug report and it works fine. I havent looked at r330745 yes, but can > replace the PR patch with that and give it a whirl.... will take a look > Monday at whats possible. > > -pete. > I based my fix heavily on that patch from the PR, but I rewrote it enough that I might've made any number of mistakes, so it needs fresh testing. The main change I made was to make it a lot less noisy while waiting (it only mentions the wait once, unless bootverbose is set, in which case it's once per second). I also removed the logic that limited the retries to nfs and zfs, because I think we can remove all the old code related to waiting that only worked for ufs and let this new retry be the way it waits for all filesystems. But that's a bigger change we can do separately; I didn't want to hold up this fix any longer. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1520725685.84937.144.camel>