Date: Thu, 14 Nov 2013 12:48:49 -0500 From: Chad Gross <avatar4d@gmail.com> To: Mark Felder <feld@freebsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: NfSen Port PATCH Message-ID: <CAHP1p-U4LyTi7L2H6UcJJHYAq=pt45bp0ZeDtjxj_s0oKdajUw@mail.gmail.com> In-Reply-To: <88E1B73E-10D0-4949-A35C-52927187F84C@FreeBSD.org> References: <CAHP1p-UJ-ZE-RcLxmrg5fsMSfKuxPk6p4Sug3A4=z2aeibKYKw@mail.gmail.com> <88E1B73E-10D0-4949-A35C-52927187F84C@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
No problem; it happens.
Chad
On Wed, Nov 13, 2013 at 5:20 PM, Mark Felder <feld@freebsd.org> wrote:
>
> On Nov 13, 2013, at 12:27, Chad Gross <avatar4d@gmail.com> wrote:
>
> > I found an issue with the nfsen port Makefile. It is not properly
> > configured to expand the %%PORTNAME%% variable used when generating the
> > nfsen config file.
> >
> >
> > For example, the config that is installed shows this:
> >
> > $VARDIR=3D"${BASEDIR}/var/%%PORTNAME%%";
> >
> >
> > When it should be this:
> >
> > $VARDIR=3D"${BASEDIR}/var/nfsen";
> >
> > I have attached the patch, but also included it in-line below. I emaile=
d
> > the maintainer, but hadn't heard a response so figured I would send it
> here
> > just in case.
> >
> >
> > --- Makefile 2013-11-03 12:31:00.000000000 -0500
> >
> > +++ Makefile.new 2013-11-03 12:30:51.000000000 -0500
> >
> > @@ -37,6 +37,7 @@
> >
> > SUB_LIST+=3D "PORTVERSION=3D${PORTVERSION}"
> >
> > SUB_LIST+=3D "PREFIX=3D${PREFIX}"
> >
> > SUB_LIST+=3D "WWWDIR=3D${WWWDIR}"
> >
> > +SUB_LIST+=3D "PORTNAME=3D${PORTNAME}"
> >
> >
> >
> > NO_STAGE=3D yes
> >
> > post-patch:
> >
> >
> > Thanks,
> >
>
> Thanks for catching this. I=92m not sure how I missed this when I rewrote
> the port=85 I definitely tested clean installs, but I must have provided =
my
> own configs
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHP1p-U4LyTi7L2H6UcJJHYAq=pt45bp0ZeDtjxj_s0oKdajUw>