Date: Sun, 24 Jun 2001 15:32:19 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Mike Heffner <mheffner@vt.edu> Cc: Mike Barcroft <mike@q9media.com>, audit@FreeBSD.org Subject: Re: src/usr.sbin/zic patch Message-ID: <20010624223219.7FB2C3E28@bazooka.unixfreak.org> In-Reply-To: <XFMail.20010624221124.mheffner@novacoxmail.com>; from mheffner@novacoxmail.com on "Sun, 24 Jun 2001 22:11:24 -0400 (EDT)"
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Heffner <mheffner@novacoxmail.com> writes: > > On 23-Jun-2001 Mike Barcroft wrote: > | I would appreciate it if someone would commit the patch at the end of > | this message. Also available at: > | http://testbed.q9media.net/freebsd/zic.20010623.patch > ... > | > | Index: zic/private.h > | =================================================================== > | RCS file: /home/ncvs/src/usr.sbin/zic/private.h,v > | retrieving revision 1.4 > | diff -u -r1.4 private.h > | --- zic/private.h 2000/11/28 18:18:56 1.4 > | +++ zic/private.h 2001/06/23 22:19:53 > | @@ -99,7 +99,7 @@ > | void * irealloc P((void * pointer, int size)); > | void icfree P((char * pointer)); > | void ifree P((char * pointer)); > | -char * scheck P((const char *string, const char *format)); > | +const char * scheck P((const char *string, const char *format)); > > I believe `__const' should be used to not break K&R. Same goes for the > definition. Just `const' is fine since it can be defined away (e.g., cc -Dconst=). See message-id <Pine.BSF.4.21.0106041245240.53715-100000@besplex.bde.org> for comments from bde@ on this subject. > > > Mike > > -- > Mike Heffner <mheffner@[acm.]vt.edu> > Fredericksburg, VA <mikeh@FreeBSD.org> > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-audit" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010624223219.7FB2C3E28>