Date: Sat, 9 Apr 2011 19:30:22 GMT From: Mark Linimon <linimon@lonesome.com> To: freebsd-emulation@FreeBSD.org Subject: Re: kern/155903: FreeBSD32 emulation patch to support i386 X11 Server Message-ID: <201104091930.p39JUMnE093069@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/155903; it has been noted by GNATS. From: Mark Linimon <linimon@lonesome.com> To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/155903: FreeBSD32 emulation patch to support i386 X11 Server Date: Sat, 9 Apr 2011 14:27:22 -0500 ----- Forwarded message from John Wehle <john@feith.com> ----- Date: Thu, 24 Mar 2011 17:26:08 -0400 (EDT) From: John Wehle <john@feith.com> To: kostikbel@gmail.com Cc: amd64@freebsd.org Subject: Re: amd64/155903: FreeBSD32 emulation patch to support i386 X11 Server > First, please split the patch into smaller, logically self-contained > parts. E.g. the change to handle fdrop() in one place should be committed > separately. Will do. Okay to just submit the series of patches under amd64/155903 or do you want them file under separate bug reports? > The last commit is the most controversial, in fact. I understand the > reason to get the user memory for calling into pciconf ioctls, but this > is somewhat ugly. Ideally, the pci_ioctl() would be changed into wrapper > and core code, and two wrappers produced, one for the native call path, > other for compat32. I don't necessarily disagree, however that's more work than I'm planning on at the moment. > BTW, would you do the shims for other pciconf ioctls, while there ? I would have if necesary (since I was there). However at a quick glance of pciio.h it didn't appear to me to be necessary. Also I do suspect that the i386 X11 Server is making successfuly use of some of the other calls. Keep in mind that the freebsd32 layer has generic handling for those ioctl calls that don't require anything special. I believe PCIOCREAD, PCIOCWRITE, and friends fall into that category since it appears the structures don't change size or alignment between i386 and amd64 (mind you this was based just on a quick glance at the header). -- John ------------------------------------------------------------------------- | Feith Systems | Voice: 1-215-646-8000 | Email: john@feith.com | | John Wehle | Fax: 1-215-540-5495 | | ------------------------------------------------------------------------- ----- End forwarded message -----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104091930.p39JUMnE093069>