Date: Sat, 4 Mar 2017 14:23:30 -0800 From: Ngie Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Bryan Drewery <bdrewery@freebsd.org>, rgrimes@freebsd.org, Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc Message-ID: <AA8BB525-8261-421B-A700-D983C6897D8A@gmail.com> In-Reply-To: <CANCZdfpq-jkHOF_a6A09tKBj7LvyssiLrrOePeS79V4Cxbgo0A@mail.gmail.com> References: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net> <7ed86250-8f8e-d034-0959-dc46e8973583@FreeBSD.org> <CANCZdfpq-jkHOF_a6A09tKBj7LvyssiLrrOePeS79V4Cxbgo0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mar 4, 2017, at 13:43, Warner Losh <imp@bsdimp.com> wrote:
>=20
>> On Sat, Mar 4, 2017 at 1:25 PM, Bryan Drewery <bdrewery@freebsd.org> wrot=
e:
>>> On 3/4/2017 12:20 PM, Rodney W. Grimes wrote:
>>> -- Start of PGP signed section.
>>> [ Charset windows-1252 unsupported, converting... ]
>>>>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote:
>>>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we are ob=
scuring
>>>>> ../.. into makefile syntax magic, probably not a grand idea.
>>>> It just trims off the last directory component. This both reduces
>>>> namecache lookups, lessens the amount of data in a log, and makes
>>>> debugging a log simpler by not having a crazy path like:
>>>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../de=
v/usb/template/usb_template.c
>>>>=20
>>>> It's far simpler to understand and work with:
>>>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c
>>>>=20
>>>> The only downside is it is slightly more obscure in a Makefile, but onc=
e
>>>> you know what :H is then it's not a problem. This is why SRCTOP is eve=
n
>>>> better than this as it is far more clear than even :H and avoids the
>>>> ../../ problems.
>>> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It appears=
>>> that we now have a mix and mashed up some one way others the other.
>>=20
>> That I can agree with. I would prefer to standardize on SRCTOP as :H is
>> too obscure without learning about make details.
>=20
> :H is insane in 90% of the cases I've seen it used. Let's roll with
> SRCTOP everywhere we can. That's safer from directory motion anyway...
Ok, I have 3 votes for SRCTOP, so I'll implement the remaining change using S=
RCTOP (for usr.bin), and reimplement the previous changes using SRCTOP.
Thank you all for the input,
-Ngie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AA8BB525-8261-421B-A700-D983C6897D8A>