Date: Tue, 29 Jun 2004 19:17:57 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Hye-Shik Chang <perky@i18n.org> Cc: Michael Nottebrock <michaelnottebrock@gmx.net> Subject: Re: A question about dependencies Message-ID: <4391E0B7-C9F0-11D8-9FE1-00039312D914@fillmore-labs.com> In-Reply-To: <20040629170416.GA87430@i18n.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hye-Shik Chang wrote:
> On Tue, Jun 29, 2004 at 06:54:44PM +0200, Michael Nottebrock wrote:
>> On Tuesday 29 June 2004 18:41, Hye-Shik Chang wrote:
>>
>>> Without runtime depencency, they will need some treatments to remove
>>> python site packages directory ($PREFIX/lib/python2.3/site-packages).
>>> I see that splitting python ports out from libxml2 and libxslt port
>>> would be better than that.
>>
>> Perhaps. However, it would still be nice to be able to USE_PYTHON in
>> such a
>> slave port. Is there no way to add some shimmies to bsd.python.mk so a
>> buildtime only dependency becomes feasible?
>>
>
> Okay. Please review this patch whether it's enough to resolve the
> problem.
>
> Index: Mk/bsd.python.mk
> ===================================================================
> RCS file: /home/pcvs/ports/Mk/bsd.python.mk,v
> retrieving revision 1.50
> diff -u -r1.50 bsd.python.mk
> --- Mk/bsd.python.mk 21 Jun 2004 01:33:52 -0000 1.50
> +++ Mk/bsd.python.mk 29 Jun 2004 17:01:35 -0000
> @@ -275,11 +275,17 @@
> .endif
>
> # dependencies
> -PYTHON_NO_DEPENDS?= NO
> +PYTHON_NO_DEPENDS?= NO
> +PYTHON_NO_BUILD_DEPENDS?= NO
> +PYTHON_NO_RUN_DEPENDS?= NO
>
> .if ${PYTHON_NO_DEPENDS} == "NO"
> +.if ${PYTHON_NO_BUILD_DEPENDS} == "NO"
> BUILD_DEPENDS+= ${PYTHON_CMD}:${PYTHON_PORTSDIR}
> +.endif
> +.if ${PYTHON_NO_RUN_DEPENDS} == "NO"
> RUN_DEPENDS+= ${PYTHON_CMD}:${PYTHON_PORTSDIR}
> +.endif
> .endif # ${PYTHON_NO_DEPENDS} == "NO"
>
> .if defined(USE_ZOPE)
I would like something more uniform, like USE_PYTHON_BUILD,
USE_PYTHON_RUN checked with defined(). The above seems to be too
sensitive to bugs like PYTHON_NO_DEPENDS=no, and it is not obvious what
..._NO_... = "NO" means, contrary to ..._NO_... = "yes".
-Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4391E0B7-C9F0-11D8-9FE1-00039312D914>