Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Jan 2021 10:16:09 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 251153] net/rdesktop 1.9.0 core dumps
Message-ID:  <bug-251153-7788-itgFffVxdV@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-251153-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-251153-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251153

--- Comment #9 from rozhuk.im@gmail.com ---
(In reply to Ivan from comment #8)

I found in mail list that gnutls_x509_crt_get_fingerprint() fails with -72 =
for
rdesktop.


Typical usage for gnutls_x509_crt_get_fingerprint():

int error;
uint8_t digest[1024];
size_t digest_size;

digest_size =3D sizeof(digest);
error =3D gnutls_x509_crt_get_fingerprint(crt_list[0],
    GNUTLS_DIG_MD5, digest, &digest_size);

on error digest_size not changed.


I am does not see rdesktop code, but suspect that it does not proper handle
error for gnutls_x509_crt_get_fingerprint().
Probably more proper fix would be add error handler and set digest_size to
zero:

error =3D gnutls_x509_crt_get_fingerprint(crt_list[0],
    GNUTLS_DIG_MD5, digest, &digest_size);
if (0 !=3D error) {
        digest_size =3D 0;
}

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-251153-7788-itgFffVxdV>