Date: Sun, 11 Jan 2015 23:02:24 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276962 - head/lib/liblzma Message-ID: <20150111220223.GB17273@ivaldir.etoilebsd.net> In-Reply-To: <20150111212744.GE42409@kib.kiev.ua> References: <201501110925.t0B9P2Sg005368@svn.freebsd.org> <20150111212744.GE42409@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 11, 2015 at 11:27:44PM +0200, Konstantin Belousov wrote: > On Sun, Jan 11, 2015 at 09:25:02AM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sun Jan 11 09:25:01 2015 > > New Revision: 276962 > > URL: https://svnweb.freebsd.org/changeset/base/276962 > >=20 > > Log: > > Do not regenerate and install liblzma.pc when only build libraries > > aka do not regenerate while generating 32bits libs > > =20 > > Reported by: antoine > >=20 > > Modified: > > head/lib/liblzma/Makefile > >=20 > > Modified: head/lib/liblzma/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/liblzma/Makefile Sun Jan 11 08:40:01 2015 (r276961) > > +++ head/lib/liblzma/Makefile Sun Jan 11 09:25:01 2015 (r276962) > > @@ -148,12 +148,13 @@ CFLAGS+=3D -DSYMBOL_VERSIONING > > =20 > > CLEANFILES+=3D liblzma.pc > > =20 > > +.if !defined(LIBRARIES_ONLY) > > all: liblzma.pc > I think that much better define to differentiate on would be COMPAT_32BIT. >=20 > That said, head and stable/10 should be almost clean now for allowing > ports and third-party software to work with cc -m32. I think > that this commit makes it in other direction. >=20 > Could the .pc files for base system provided by some port ? >=20 I think the best would probably be to create a bsd.pc.mk which act a bit li= ke bsd.incs.mk Concerning pushing all of those .pc files into a port, I'm not against it, actually it would be even simpler for ports as it will affect all the ports= at once. But on the other hands that would mean on port with different content based on OSVERSIONS, I think keeping it in base would be more accurate. Best regards, Bapt --E39vaYmALEf/7YXx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlSy8uwACgkQ8kTtMUmk6ExuTgCfTcaURcUPyfcMSiqi8fdQYKPD CUgAniUtyx7rfNo2nZONj2d08Ym1dQOp =WDgi -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150111220223.GB17273>