Date: Tue, 20 Nov 2012 00:08:41 +0100 From: Giovanni Trematerra <gianni@freebsd.org> To: =?UTF-8?B?xYF1a2FzeiBQxYJhY2hubw==?= <luk@semihalf.com> Cc: freebsd-arm@freebsd.org Subject: Re: ARM/SMP, Some patches for review. Message-ID: <CACfq093LakTKEf8E3L5S7QnYcgdnBVpnFSRJo%2BMx=mfgbXpg0g@mail.gmail.com> In-Reply-To: <50AA4E87.3000505@semihalf.com> References: <50AA4E87.3000505@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 19, 2012 at 4:21 PM, =C5=81ukasz P=C5=82achno <luk@semihalf.com=
> wrote:
> Hi,
>
> I would like to propose few changes for ARM specific code.
> Three attached patches for freebsd-current allows building SMP-safe world
> for ARM targets and turns on TEX remap for ARMv6 and ARMv7 targets.
>
> More details inside patch files.
>
> Change introduced by "commit-2" removes armv7 targets (armv7 and pj4b) fr=
om
> kernel.tramp.
> AFAIK this feature is not working properly for armv7 targets and is causi=
ng
> problem during compilation:
> - LOCORE is defined during kernel compilation but not defined during
> kernel.tramp compilation, so #include pmap.h causes build errors.
>
> I do not think adding hack like this:
> #ifndef LOCORE
> #define LOCORE
> #endif
>
> to allow building something that is already broken is a good idea, so I
> removed cpufunc_asm_pj4b.S and cpufunc_asm_armv7.S from Makefile.arm
In commit-2.txt
you should include style changes in sys/arm/arm/cpufunc_asm_armv7.S
into a different patch.
@@ -63,7 +64,6 @@ FILES_CPU_FUNC =3D $S/$M/$M/cpufunc_asm_arm7tdmi.S \
$S/$M/$M/cpufunc_asm_xscale.S $S/$M/$M/cpufunc_asm.S \
$S/$M/$M/cpufunc_asm_xscale_c3.S $S/$M/$M/cpufunc_asm_armv5_ec.S \
$S/$M/$M/cpufunc_asm_fa526.S $S/$M/$M/cpufunc_asm_sheeva.S \
- $S/$M/$M/cpufunc_asm_pj4b.S $S/$M/$M/cpufunc_asm_armv7.S
You left a trailing back slash but beside that you should clean up
sys/arm/arm/elf_trampoline.c
and not make kernel.tramp to build at all for armv7 cpus or you'll end
up with a linker error
during generation of the kernel.tramp.
--
Gianni
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACfq093LakTKEf8E3L5S7QnYcgdnBVpnFSRJo%2BMx=mfgbXpg0g>