Date: Tue, 21 Sep 2010 09:39:23 -0700 From: mdf@FreeBSD.org To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212964 - head/sys/kern Message-ID: <AANLkTik4BDuk3jbJTHqw5D9ih77gYHj9s0V%2B7sLOKX9i@mail.gmail.com> In-Reply-To: <4C98DF25.9040100@freebsd.org> References: <201009211507.o8LF7iVv097676@svn.freebsd.org> <AANLkTi=CTr%2BZDs3znsF-SXDp__xxbetjnhSBxiDhfFYy@mail.gmail.com> <4C98CEE7.6060802@freebsd.org> <4C98D200.4040909@freebsd.org> <AANLkTim%2BZYppETzFOYrGjhsEXr9hVPi8L0Mvaa6RkhMq@mail.gmail.com> <4C98DF25.9040100@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 21, 2010 at 9:36 AM, Andriy Gapon <avg@freebsd.org> wrote: > on 21/09/2010 19:31 mdf@FreeBSD.org said the following: >> I keep forgetting, but actually _mtx_lock_sleep() will just return if >> panicstr is set. =A0_mtx_assert() is similarly guarded, so actually it >> should be mostly okay. > > But this doesn't seem to be the case for sx lock which is wrapped under K= LD_LOCK() ? Right, that was it. I knew I hit a problem on 7 in the past. The right thing is probably to guard the sx_[sx]lock_hard primitives and sx_assert in the same way. Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTik4BDuk3jbJTHqw5D9ih77gYHj9s0V%2B7sLOKX9i>