Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Oct 2007 15:31:20 -0400 (EDT)
From:      Daniel Eischen <eischen@vigrid.com>
To:        Andrey Chernov <ache@nagual.pp.ru>
Cc:        cvs-src@FreeBSD.org, Scott Long <scottl@samsco.org>, src-committers@FreeBSD.org, d@delphij.net, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/locale utf8.c
Message-ID:  <Pine.GSO.4.64.0710251528370.29092@sea.ntplx.net>
In-Reply-To: <20071025192501.GG16187@nagual.pp.ru>
References:  <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> <4720E9E1.7000900@delphij.net> <Pine.GSO.4.64.0710251516220.29092@sea.ntplx.net> <20071025192501.GG16187@nagual.pp.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Oct 2007, Andrey Chernov wrote:

> On Thu, Oct 25, 2007 at 03:17:32PM -0400, Daniel Eischen wrote:
>> Why not simply avoid the error check for inlines.  Solaris
>> doesn't seem to add a check, it just does the conversion.
>> The non-inlined versions do error checking.
>
> Although standard permit this, it will cause lots of programs to break
> here and there and even may cause core dump. I don't think it is what
> everybody wants. Non-inlined versions a) not used nowdays b) must be exact
> as inlined.

If programs are incorrectly written, and they use inlines, then
that is not our fault :-)

The problem with trying to do error checking and other
esoteric things with inlines is that it exposes our private
parts to the world.  You can get arrested for that ;-)

How much juice are we really trying to squeeze out of
these inlines anyway?

-- 
DE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.0710251528370.29092>