Date: Tue, 16 Jul 2019 19:28:00 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r350044 - in stable/12: share/man/man4 sys/dev/gpio Message-ID: <94d937ee-e121-8882-9859-7d477e18beb4@FreeBSD.org> In-Reply-To: <201907161552.x6GFqlU5013936@repo.freebsd.org> References: <201907161552.x6GFqlU5013936@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16/07/2019 18:52, Andriy Gapon wrote: > Author: avg > Date: Tue Jul 16 15:52:47 2019 > New Revision: 350044 > URL: https://svnweb.freebsd.org/changeset/base/350044 > > Log: > MFC r349460: gpiobus: provide a new hint, pin_list > > "pin_list" allows to specify child pins as a list of pin numbers. > Existing hint "pins" serves the same purpose but with a 32-bit wide bit > mask. One problem with that is that a controller can have more than 32 > pins. One example is amdgpio. Also, a list of numbers is a little bit > more human friendly than a matching bit mask. As a side note, it seems > that in FDT pins are typically specified by their numbers as well. > > This commit also adds accessors for instance variables (IVARs) that > define the child pins. My primary goal is to allow a child to be > configured programmatically rather than via hints (assuming that FDT is > not supported on a platform). Also, while a child should not care about > specific pin numbers that are allocated to it, it could be interested in > how many were actually assigned to it. > > While there, I removed "flags" instance variable. It was unused. This change (the "flags" removal, specifically) broke build on OFW platforms (powerpc). I am working on a fix, it should be trivial. > Modified: > stable/12/share/man/man4/gpio.4 > stable/12/sys/dev/gpio/gpiobus.c > stable/12/sys/dev/gpio/gpiobusvar.h > Directory Properties: > stable/12/ (props changed) -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94d937ee-e121-8882-9859-7d477e18beb4>