Date: Fri, 30 Dec 2011 11:55:09 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Philippe Saint-Pierre <stpere@gmail.com> Cc: freebsd-wireless@freebsd.org Subject: Re: patch proposal for marvell driver Message-ID: <CAJ-VmomOE07qjpez6DFaDUBSkRR8QwUe05HYFyJ-=t1FA14pQg@mail.gmail.com> In-Reply-To: <CAB96EKRBLN2cvavtESFH0okBOBuHXVb9Gs2rjaiCT4UqeC==0A@mail.gmail.com> References: <CAB96EKRBLN2cvavtESFH0okBOBuHXVb9Gs2rjaiCT4UqeC==0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30 December 2011 10:10, Philippe Saint-Pierre <stpere@gmail.com> wrote: > Hi, > > I'm sending this small patch for the marvell wifi driver. > > Basically, in mwl_hal_bastream_alloc(), there is a sp = ... assignment that > could return NULL, then several derefencing of sp then finally, a NULL > check on sp before returning. > > I simply moved the NULL check before the dereferences tries occurs. Thanks for noticing this! I haven't yet tried any of the mwl cards Sam gave me. Would you mind throwing this into a PR? Thanks, Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomOE07qjpez6DFaDUBSkRR8QwUe05HYFyJ-=t1FA14pQg>