Date: Sun, 17 May 2015 19:08:10 +0100 From: Andrew Turner <andrew@fubar.geek.nz> To: Cy Schubert <cy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282415 - head/usr.sbin/ntp Message-ID: <20150517190810.4006b7bb@bender.Home> In-Reply-To: <201505041242.t44CgrTd090709@svn.freebsd.org> References: <201505041242.t44CgrTd090709@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 4 May 2015 12:42:53 +0000 (UTC) Cy Schubert <cy@FreeBSD.org> wrote: > Author: cy > Date: Mon May 4 12:42:52 2015 > New Revision: 282415 > URL: https://svnweb.freebsd.org/changeset/base/282415 > > Log: > Restore CPU dependent compile time conditionals. > > MFC after: 1 month (with r281143 and r282408) Do you have any plans on fixing this before you MFC it? Specifically: * sizeof(char *) == 8 on arm64, powerpc64, and mips64 * sizeof(long) == 8 on arm64, powerpc64, and mips64 * sizeof(time_t) == 8 on arm, arm64, powerpc64, mips, and mips64 * STR_SYSTEM is incorrect on arm, arm64, powerpc64, mips, and mips64, however this is now less broken as it was previously also broken on i386, and sparc64. This change is only correct for amd64, i386, and sparc64. I suspect all of the above will also be relevant on ia64. We still have support in 10-STABLE for this so should be fixed before an MFC. I have heard reports that NTP is broken on some of the above platforms so they don't keep very accurate time. Can you fix this, or revert this change until a fix can be written. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150517190810.4006b7bb>