Date: Fri, 22 May 1998 08:01:32 +1000 (EST) From: Darren Reed <darrenr@reed.wattle.id.au> To: eivind@yes.no (Eivind Eklund) Cc: jkh@time.cdrom.com, gibbs@plutotech.com, jkh@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h Message-ID: <199805212201.IAA12733@avalon.reed.wattle.id.au> In-Reply-To: <19980521202541.60347@follo.net> from Eivind Eklund at "May 21, 98 08:25:41 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
In some email I received from Eivind Eklund, sie wrote: > On Thu, May 21, 1998 at 10:12:50AM -0700, Jordan K. Hubbard wrote: > > > No, no, no. Create an osreldate.h file instead. Please? Using __FreeBSD__ > > > doesn't work because it's tied to the compiler, not the source. > > > > 1. The osreldate.h file just isn't created in time and if we want > > our SNAP builds to work for now, this change has to happen. > > If we want to work out how to get the osreldate.h file bootstrapped > > into place at a later time then that's fine with me, but there's > > no use holding up the show until then. > > That was the change I installed and backed out so fast earlier today; > it unfortunately didn't work. > > > 2. Absolutely *nothing* else in the system that I've been able to > > find uses __FreeBSD_version directly in the way that this driver > > did. If this is really a step forward then I'd suggest that > > a whole lot more needs changing if self-consistency is also your > > goal (and I think it should be, especially where this kind of > > stuff is concerned, since other driver writers will imitate it). > > The reason nothing else use __FreeBSD_version directly in this way is > that we don't provide it to kernel files, and that _suck_. It is one > of the biggest hurdles for people attempting to do development outside > of the FreeBSD tree proper. FWIW, when the shell setup script for in-kernel compiles of IP Filter is run, it copies /usr/include/osreldate.h to /sys/sys. It might not be a "great" idea, but heck, it's better than having nothing to use. Darren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805212201.IAA12733>