Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Sep 2009 18:51:59 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Jimmy Olgeni <olgeni@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/lang/erlang Makefile
Message-ID:  <20090906185159.GA53124@FreeBSD.org>
In-Reply-To: <alpine.BSF.2.00.0909061939240.36316@olgeni.olgeni>
References:  <200909061320.n86DK7de072438@repoman.freebsd.org> <20090906172642.GA42149@FreeBSD.org> <alpine.BSF.2.00.0909061939240.36316@olgeni.olgeni>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 06, 2009 at 07:43:07PM +0200, Jimmy Olgeni wrote:
> On Sun, 6 Sep 2009, Alexey Dokuchaev wrote:
> >On Sun, Sep 06, 2009 at 01:20:07PM +0000, Jimmy Olgeni wrote:
> >>olgeni      2009-09-06 13:20:07 UTC
> >>
> >>  FreeBSD ports repository
> >>
> >>  Modified files:
> >>    lang/erlang          Makefile
> >>  Log:
> >>  Use "+=" rather than "=" when modifying CONFIGURE_ENV.
> >
> >It could be useful to know what was particularly wrong with "=" without
> >reading through Makefile.
> 
> In this case it was overriding a CONFIGURE_ENV a few lines above, thus 
> losing the JDK path setting. Should I follow up with a forced commit?

This case is simple enough so it's probably not worth it, but thanks for
explanation.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090906185159.GA53124>