Date: Sat, 6 Apr 2013 09:03:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>, svn-ports-all@freebsd.org, Eitan Adler <eadler@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict Message-ID: <20130406090344.GB8364@FreeBSD.org> In-Reply-To: <CAMHz58TjHwW9iKb2jSSBUrWk-zqt4%2B4PDfxxcqBZVxShg_YjTA@mail.gmail.com> References: <201303251359.r2PDxIXf035701@svn.freebsd.org> <20130328025321.GC72629@FreeBSD.org> <CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw@mail.gmail.com> <CAMHz58TjHwW9iKb2jSSBUrWk-zqt4%2B4PDfxxcqBZVxShg_YjTA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 04, 2013 at 05:24:32PM +0800, Sunpoet Po-Chuan Hsieh wrote: > If maintainers think these options are annoying, they could put them to the > end of OPTIONS_DEFINE. Option knobs are sorted by default, so their position within OPTIONS_DEFINE does not usually matter. > > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set > > globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can > > reduce user annoyance if the dialog box is not shown for such options. The problem, however, is that sometimes DOCS really mean "build the docs with some <heavy-stuff>, ergo pull lots of extra bdeps" rather than "copy few docs into $docsdir". I usually prefer to see if the former starts to happen to quickly hit ^C and disable [misused] DOCS option. That said, in general I think it's better to list DOCS et al. even if there're no other options (that is, always). Maybe it makes sense to introduce a knob to suppress dialog pop-up when OPTIONS_DEFINE contains only things like IPV6, DOCS, EXAMPLES, and NLS. It can be opt-in or opt-out, but at least every option would consistently be listed in OPTIONS_DEFINE. This is also good for various ports sanity checks, for example -- less special hacks to introduce. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130406090344.GB8364>