Date: Mon, 19 Sep 2016 14:22:37 -0700 From: John Baldwin <jhb@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr Message-ID: <8333248.dV1m5xp1ki@ralph.baldwin.cx> In-Reply-To: <E52FB33D-0921-404F-8457-0E2CB957556B@gmail.com> References: <201609192043.u8JKh3jv040006@repo.freebsd.org> <E52FB33D-0921-404F-8457-0E2CB957556B@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: >=20 > > On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer <cem@FreeBSD.org> wrot= e: > >=20 > > Author: cem > > Date: Mon Sep 19 20:43:03 2016 > > New Revision: 305998 > > URL: https://svnweb.freebsd.org/changeset/base/305998 > >=20 > > Log: > > Move sys/capsicum.h includes after types.h or param.h > >=20 > > This is not actually documented or even implied in style(9). Make= the change > > to match convention. Someone should document this convention in s= tyle(9). > >=20 > > Reported by:=09jhb > > Sponsored by:=09EMC Dell Isilon >=20 > Uh=E2=80=A6 yes it clearly states it in style(9). From https://www.fr= eebsd.org/cgi/man.cgi?query=3Dstyle&sektion=3D9 : > Kernel include files (i.e. sys/*.h) come first; normally, includ= e > <sys/types.h> OR <sys/param.h>, but not both. <sys/types.h> inc= ludes > <sys/cdefs.h>, and it is okay to depend on that. It doesn't actually say that types.h/param.h has to come before other s= ys/*.h headers though. Normally sys/foo.h requires sys/types.h to compile hen= ce the rule, but sys/capsicum.h gets around this by a nested include of sys/pa= ram.h (which is itself probably dubious). I do think we should explicitly add a note to style.9 though to say tha= t types.h|param.h comes first. --=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8333248.dV1m5xp1ki>