Date: Sat, 1 Oct 2016 07:43:39 -0500 From: Lewis Donzis <lew@perftech.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Alexander Kabaev <kabaev@gmail.com>, deischen@freebsd.org, freebsd-arch@freebsd.org Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11 Message-ID: <7CEF9718-2583-4EF1-BBBA-34A3B2F2F0E0@perftech.com> In-Reply-To: <20161001092515.GW38409@kib.kiev.ua> References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> <20160930152006.GS38409@kib.kiev.ua> <20160930184418.1047afc2@kan> <20161001092515.GW38409@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 1, 2016, at 4:25 AM, Konstantin Belousov <kostikbel@gmail.com> =
wrote:
>=20
> On Fri, Sep 30, 2016 at 06:44:18PM -0400, Alexander Kabaev wrote:
>> No objection, but possible suggestion: if the primary use of this
>> symbol is for tests and nothing else, maybe it does belong in
>> FBSDprivate_1.0 FBSDprivate_1.0 section instead?
>=20
> Good question. The symbols are useful for real-world code, not only =
for
> the tests. But I think that we should mark symbol as non-portable. =
Usual
> approach of adding _np suffix seems to be the right thing to do there.
>=20
> What about the following ?
> =E2=80=A6
Not that I have any say in this, but that seems reasonable to me. The =
functions are relevant and necessary for anything that needs a handle =
for a POSIX message queue, so your change would be preferable to having =
them appear as internal functions. (And then they could be documented, =
too.)
Speaking of which, not sure if this is the appropriate place to post =
this, but the mq_open documentation needs a little tweaking, too.
mq_open(2)=E2=80=99s man page says:
SEE ALSO
mq_close(2), mq_getattr(2), mq_receive(2), mq_send(2), =
mq_setattr(2),
mq_timedreceive(3), mq_timedsend(3), mq_unlink(3), mqueuefs(5)
However, both mq_timedreceive and mq_timedsend are in section 2, not =
section 3. =20
And, mq_unlink should probably be in section 2, but in any event, that =
file appears to be missing.
lew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7CEF9718-2583-4EF1-BBBA-34A3B2F2F0E0>