Date: Tue, 04 Nov 2008 22:41:51 -0800 From: Tim Kientzle <tim@kientzle.com> To: d@delphij.net Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, Tim Kientzle <kientzle@FreeBSD.ORG>, src-committers@FreeBSD.ORG Subject: Re: svn commit: r184668 - head/usr.bin/tar/test Message-ID: <4911402F.2000305@kientzle.com> In-Reply-To: <491133B1.9050208@delphij.net> References: <200811050526.mA55QBk4017410@svn.freebsd.org> <491133B1.9050208@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI wrote: >>Author: kientzle >>Date: Wed Nov 5 05:26:11 2008 >>New Revision: 184668 >>URL: http://svn.freebsd.org/changeset/base/184668 >> >> >[...] > > >>@@ -494,7 +494,8 @@ test_assert_empty_file(const char *f1fmt >> if (fd < 0) { >> fprintf(stderr, " Unable to open %s\n", f1); >> } else { >>- s = sizeof(buff) < st.st_size ? sizeof(buff) : st.st_size; >>+ s = (sizeof(buff) < (size_t)st.st_size) ? >>+ (ssize_t)sizeof(buff) : (ssize_t)st.st_size; >> >> > >I'm more or less concerned about this - st_size is off_t, is it safe to >cast it to size_t when comparing here? > > Thanks. I've fixed this. Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4911402F.2000305>