Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Nov 2019 22:55:35 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Brooks Davis <brooks@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r354694 - in head: lib/libc/gen sys/sys
Message-ID:  <20191113225535.GA17978@spindle.one-eyed-alien.net>
In-Reply-To: <20191113224640.GX2707@kib.kiev.ua>
References:  <201911132151.xADLptvc074883@repo.freebsd.org> <20191113224640.GX2707@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 14, 2019 at 12:46:40AM +0200, Konstantin Belousov wrote:
> On Wed, Nov 13, 2019 at 09:51:55PM +0000, Brooks Davis wrote:
> > Author: brooks
> > Date: Wed Nov 13 21:51:55 2019
> > New Revision: 354694
> > URL: https://svnweb.freebsd.org/changeset/base/354694
> >=20
> > Log:
> >   elf_aux_info: Add support for AT_EXECPATH.
> >  =20
> >   Reviewed by:	emaste, sef
> >   MFC after:	3 days
> >   Sponsored by:	DARPA, AFRL
> >   Differential Revision:	https://reviews.freebsd.org/D22353
> >=20
> > Modified:
> >   head/lib/libc/gen/auxv.3
> >   head/lib/libc/gen/auxv.c
> >   head/sys/sys/param.h
> >=20
> > Modified: head/lib/libc/gen/auxv.3
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/lib/libc/gen/auxv.3	Wed Nov 13 21:49:46 2019	(r354693)
> > +++ head/lib/libc/gen/auxv.3	Wed Nov 13 21:51:55 2019	(r354694)
> > @@ -24,7 +24,7 @@
> >  .\"
> >  .\" $FreeBSD$
> >  .\"
> > -.Dd April 25, 2019
> > +.Dd November 13, 2019
> >  .Dt ELF_AUX_INFO 3
> >  .Os
> >  .Sh NAME
> > @@ -48,6 +48,10 @@ can be requested:
> >  .Bl -tag -width AT_OSRELDATE
> >  .It AT_CANARY
> >  The canary value for SSP.
> > +.It AT_EXECPATH
> > +The path of executed program.
> > +This will not be present if the process was initialized by
> This is too strong statement.  The auxv element might be not present
> if vn_fullpath(9) failed, otherwise we do provide the path.
>=20
> > +.Xr fexecve 2 .

Would it be more accurate to change it from "will" to "may"?
Referencing vn_fullpath(9) seems unhelpful in userspace programmer
documentation.

-- Brooks

--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJdzInnAAoJEKzQXbSebgfAjVAH/jFv9jpaVtqOvHJc4+XDPeVJ
4dbHxff5z8VgSRgGqkSbVuRf4s3DySQWd5553941Toc/EqzYEZfwAZGSomwDk/Ct
sr5Oybye2GyvwItruiztZNDikeJB71g8sRO8QRcRIt3R9B+HKgC8dTaR9EgZ9pfL
LE1E87hCGQoSg/kIPLqBi+TCqDqFn1b96GWKjTOs+fyuU5E6QMv9O6ZMuqbOWYSV
y7qS8HMjg4fRF5r/o2rlLnwXXd4buNVd8nvwudmnS1zfSNCMIXrtA2zh6i+cFpyz
iDedn3rom9yNTwMtmUWd1qA2TBDvYNUKVWfcXoMD9Gv8cJrNYVzQgy+i4Q3/JMY=
=Q4/Z
-----END PGP SIGNATURE-----

--C7zPtVaVf+AK4Oqc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191113225535.GA17978>