Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Jul 1994 22:23:39 -0700 (PDT)
From:      "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
To:        phk@freefall.cdrom.com (Poul-Henning Kamp)
Cc:        ache@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-lib@freefall.cdrom.com, davidg@freefall.cdrom.com, dyson@freefall.cdrom.com, jkh@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, sean@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, wollman@freefall.cdrom.com
Subject:   Re: cvs commit: src/lib/libmd .depend
Message-ID:  <199407250523.WAA24861@gndrsh.aac.dev.com>
In-Reply-To: <199407242055.NAA29670@freefall.cdrom.com> from "Poul-Henning Kamp" at Jul 24, 94 01:55:13 pm

next in thread | previous in thread | raw e-mail | index | archive | help
> 
> phk         94/07/24 13:55:12
> 
>   Removed:     lib/libmd .depend
>   Log:
>   Reviewed by:	phk
^^^^^^^^^^^^^^^^^^^^^^^^^^^

>   zapped a .depend which had crept in.
> 

You are not reading what it says.... you are the author of this patch:

CVS: Delete the ``Reviewed by'' line if this is somebody else's work

CVS: Delete the ``Submitted by'' line if this is NOT somebody else's
CVS: work (you are the author).

This should have looked like this:

phk         94/07/24 13:55:12

  Removed:     lib/libmd .depend
  Log:
  Submitted by:        phk

  zapped a .depend which had crept in.


And note.. this was a trivial thing that really does not warrant review,
but be thinking about haveing all changes reviewed... so you can fill
in BOTH lines... and probably stop a lot of bad commits.  That is what
I believe Garrett had in mind when he added the rcstemplate stuff.

-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199407250523.WAA24861>