Date: Mon, 25 Aug 2014 15:17:52 -0400 From: John Baldwin <jhb@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, peter@wemm.org, Don Lewis <truckman@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, Rui Paulo <rpaulo@felyko.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r270510 - head Message-ID: <3014037.G9yExtHamp@ralph.baldwin.cx> In-Reply-To: <53FB81E9.1010407@FreeBSD.org> References: <61DA1EC8-C938-4AB8-B518-7249307B4379@felyko.com> <CAJ5_RoBMwpoph617iSrgj2%2BxGyFm_R3Az21v-UB_53_mnKdaZA@mail.gmail.com> <53FB81E9.1010407@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, August 25, 2014 01:35:21 PM Bryan Drewery wrote: > On 8/25/2014 12:36 PM, Benjamin Kaduk wrote: > > On Mon, Aug 25, 2014 at 10:10 AM, Gleb Smirnoff <glebius@freebsd.org > > > > <mailto:glebius@freebsd.org>> wrote: > > And carrying this stuff costs us almost nothing. > > > > The cost of having it in the tree is small, yes. But the runtime cost > > when people actually run delete-old will only keep increasing ... it > > already feels kind of slow, to me. > > > > -Ben > > This could be fixed by not calling rm(1) for every file but instead > using xargs rm so it is called only a few times, when not needing -i. > The same goes for the chflags and -f/-L tests. It would be much more > manageable if all of the logic moved into a shell script. rm -i foo bar still prompts individually for each file, so presumably you could always use 'xargs | rm'? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3014037.G9yExtHamp>