Date: Fri, 01 Jun 2007 12:13:32 +0200 From: Thomas Spreng <spreng@socket.ch> To: "Max N. Boyarov" <m.boyarov@bsd.by> Cc: ports@freebsd.org Subject: Re: net/rdesktop segfault Message-ID: <465FF14C.8090205@socket.ch> In-Reply-To: <86y7jdmedl.fsf@bsd.by> References: <863b1lnurb.fsf@bsd.by> <86y7jdmedl.fsf@bsd.by>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------060300060704010706050002
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Hi,
> after clean install xorg7.2 rdesktop segfault at login.
same problem here, after upgrading xorg to v7.2 rdesktop segfaults on
each login attempt. This seems to be a known problem with rdesktop.
Based on a PR from Ubuntu, I've created a patch which should resolve
this problem (see attachment).
I'll send it in as a PR tonight.
PS: apply with
(cd /usr/ports/net/rdesktop && patch -p1 < /path/to/patch)
PPS: forgot to cc: to list.
cheers,
tom.
--------------060300060704010706050002
Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0";
name="rdesktop-1.5.0_2.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="rdesktop-1.5.0_2.diff"
diff -ruN rdesktop.bak/Makefile rdesktop/Makefile
--- rdesktop.bak/Makefile Sat May 19 22:18:54 2007
+++ rdesktop/Makefile Fri Jun 1 11:30:39 2007
@@ -7,7 +7,7 @@
PORTNAME= rdesktop
PORTVERSION= 1.5.0
-PORTREVISION?= 1
+PORTREVISION?= 2
CATEGORIES= net comms
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= ${PORTNAME}
diff -ruN rdesktop.bak/files/patch-xwin.c rdesktop/files/patch-xwin.c
--- rdesktop.bak/files/patch-xwin.c Thu Jan 1 01:00:00 1970
+++ rdesktop/files/patch-xwin.c Fri Jun 1 11:30:39 2007
@@ -0,0 +1,11 @@
+--- xwin.c.orig Fri Jun 1 10:27:15 2007
++++ xwin.c Fri Jun 1 10:28:26 2007
+@@ -3219,7 +3219,7 @@
+ return;
+
+ image = XCreateImage(g_display, g_visual, g_depth, ZPixmap, 0,
+- (char *) data, cx, cy, BitmapPad(g_display), cx * g_bpp / 8);
++ (char *) data, cx, cy, g_bpp, 0);
+
+ if (g_ownbackstore)
+ {
--------------060300060704010706050002--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?465FF14C.8090205>