Date: Thu, 26 Aug 2004 15:10:30 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c Message-ID: <20040826131030.GO30151@darkness.comp.waw.pl> In-Reply-To: <58622.1093524972@critter.freebsd.dk> References: <200408261242.i7QCgl7m012027@repoman.freebsd.org> <58622.1093524972@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--AhNoKa8EeSU2TVlt Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 26, 2004 at 02:56:12PM +0200, Poul-Henning Kamp wrote: +> In message <200408261242.i7QCgl7m012027@repoman.freebsd.org>, Pawel Jaku= b Dawid +> ek writes: +>=20 +> > Log: +> > Skip providers with not defined sector size. +>=20 +> This is wrong. A provider with a non-zero access count should always +> have a sector size. The sectorsize can not be trusted if the access +> counts are zero. Yes, I know that it should be done this way, but I'm not going to fix atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else. Those classes set error to 0 even when provider has not sectorsize and mediasize defined. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --AhNoKa8EeSU2TVlt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBLeFGForvXbEpPzQRAoFXAJ4kkZACzU72UkoXl2ZTdLHj5JReAQCggfvQ gJEMDEGwE43rfzdjTy1CAOM= =l9RB -----END PGP SIGNATURE----- --AhNoKa8EeSU2TVlt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040826131030.GO30151>