Date: Sat, 24 Dec 2011 17:57:21 +0100 From: Lars Engels <lars.engels@0x20.net> To: Warner Losh <imp@bsdimp.com> Cc: Chris Rees <crees@FreeBSD.org>, Maxim Ignatenko <gelraen.ua@gmail.com>, freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr Message-ID: <20111224165721.GZ13272@e-new.0x20.net> In-Reply-To: <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <CADLo83-SK%2Bo0b9GysjhH0N=TxsZXLRAuKL-n%2Btt6%2BCcr1gAJWQ@mail.gmail.com> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nktOf83SvqltY3iw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 24, 2011 at 09:48:37AM -0700, Warner Losh wrote: >=20 > On Dec 24, 2011, at 6:15 AM, Chris Rees wrote: >=20 > > On 24 December 2011 12:30, Maxim Ignatenko <gelraen.ua@gmail.com> wrote: > >> The following reply was made to PR conf/163508; it has been noted by G= NATS. > >>=20 > >> From: Maxim Ignatenko <gelraen.ua@gmail.com> > >> To: Doug Barton <dougb@freebsd.org> > >> Cc: bug-followup@freebsd.org > >> Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and > >> "disable" commands to rc.subr > >> Date: Sat, 24 Dec 2011 14:20:19 +0200 > >>=20 > >> On 24 December 2011 04:15, Doug Barton <dougb@freebsd.org> wrote: > >> > This idea has been considered before and rejected because it's too > >> > difficult to catch all the corner cases, and actually editing a con= fig > >> > file is not really all that hard of a thing to do. > >> > > >>=20 > >> The idea was to make enabling/disabling services less error-prone. It > >> don't need to catch _all_ corner cases, because if administrator do > >> something unusual with startup configuration he should be able to > >> manipulate it in proper way, or even have tools that do something > >> similar. > >> Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and > >> /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of > >> cases. > >> Doing `service someserive enable` is much faster and less error-prone > >> that `service someservice rcvar ; echo someservicercvar_enable=3DYES = >> > >> /etc/rc.conf` > >=20 > > Disagree, sorry. > >=20 > > If we're going to implement these ideas we should do it properly, not > > for 95% of cases. >=20 > A lot depends on what those 5% of the cases are. Absent an > implementation to throw stones at, such criticism is premature. If > the 5% of cases are when someone has done something complicated to the > rc.conf file, then I don't care: they won't use this interface and we > can detect this case and do nothing. If the 5% of the cases are when > someone has enabled ntpd, then that would be a non-starter. Yup, let's better fix the 5% of special cases where the new features doesn't work. I know and like the "enable / disable" arguments to "svcadm" from Solaris and miss it on FreeBSD. --nktOf83SvqltY3iw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk72BHEACgkQKc512sD3afiRSwCgu/6K5RF2XKkjGA8Q9+io2Cr2 vToAoKPSMX0sQkD8Zm3kWYY1j8R0ezM4 =Nvau -----END PGP SIGNATURE----- --nktOf83SvqltY3iw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111224165721.GZ13272>