Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jan 2002 16:00:36 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Alfred Perlstein <alfred@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/kern sys_generic.c
Message-ID:  <XFMail.020116160036.jhb@FreeBSD.org>
In-Reply-To: <200201162133.g0GLXfA36921@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 16-Jan-02 Alfred Perlstein wrote:
> alfred      2002/01/16 13:33:41 PST
> 
>   Modified files:
>     sys/kern             sys_generic.c 
>   Log:
>   Fix giant handling in pwrite(2), I forgot to release it when finishing
>   the syscall.

Uh, this isn't correct.  fdrop() can call fo_close() can call down into VFS
and do a vrele(), so fdrop() still needs Giant.  If you aren't holding Giant
across fdrop() in a few places that might explain the vput(0x0) panics.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020116160036.jhb>