Date: Sun, 7 May 1995 03:03:54 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: bde@freefall.cdrom.com (Bruce Evans) Cc: CVS-commiters@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.sbin/edquota edquota.c Message-ID: <199505071003.DAA12315@gndrsh.aac.dev.com> In-Reply-To: <199505070748.AAA09307@freefall.cdrom.com> from "Bruce Evans" at May 7, 95 00:48:38 am
next in thread | previous in thread | raw e-mail | index | archive | help
> > bde 95/05/07 00:48:37 > > Modified: usr.sbin/edquota edquota.c > Log: > Cast some expressions involving dbtob() to (unsigned long) and print them > using %lu. This became more broken when I fixed dbtob() to support byte > offsets >= 4GB. The type had to change to [u]quad_t. Previously the > expressions had type unsigned long and were printed using %d. After > division by 1024, the expressions are guaranteed to fit in an unsigned > long, at least for the standard DEV_BSIZE, so edquota doesn't need to > know about quad_t's explicitly. > > Fix all the other format mismatches exposed by compiling with -Wformat > (6 more quota limits of type unsigned long printed using %d and 6 time_t's > (i.e., longs) printed using %d). I'll try to make a pass over the whole tree with a -Wformat and see if it is a manageable task to go fix. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505071003.DAA12315>