Date: Wed, 25 Sep 2002 17:51:04 +0200 From: Roman Neuhauser <neuhauser@bellavista.cz> To: Bruce M Simpson <bms@spc.org>, freebsd-hackers@freebsd.org Subject: Re: periodic(8)-produced diffs Message-ID: <20020925155104.GR30361@freepuppy.bellavista.cz> In-Reply-To: <20020923151059.GJ23343@spc.org> References: <20020923150536.GB30361@freepuppy.bellavista.cz> <20020923151059.GJ23343@spc.org>
next in thread | previous in thread | raw e-mail | index | archive | help
# bms@spc.org / 2002-09-23 16:10:59 +0100:
> On Mon, Sep 23, 2002 at 05:05:36PM +0200, Roman Neuhauser wrote:
> [... re periodic diffs]
> > And, what would the preferred interface be? Most of periodic.conf
> > knobs are bools, but I'm not sure
> > diff_{context,traditional,unified}_format="{YES,NO}"
> > is better than
> > diff_format="{context,traditional,unified}"
>
> No reason why rc.conf knobs *have* to be bools, what ultimately
> matters is the case...esac which parses them. I'd avoid relying on a
> default value in /etc/defaults/rc.conf for the sake of robustness.
>
> I prefer unified diffs, personally.
thanks for your input. another thing I'm not sure about: should this
knob be limited to just setting the diff format? there's also the
possibility of going the rc.conf ${program}_flags path.
i guess the question is whether the interface should be limited to a
safe set of settings, or if the users should be able to shoot
themselves in the foot in any way they want.
quite a few diff switches don't make any sense in the actions
performed by the periodic scripts, but IMO it's root's duty to
choose a reasonable set.
i think i'll try the $diff_program_options route, and post the
patch later today or tomorrow.
--
begin 666 nonexistent.vbs
FreeBSD 4.7-RC
5:43PM up 8 days, 58 mins, 18 users, load averages: 0.06, 0.12, 0.07
end
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020925155104.GR30361>