Date: Fri, 03 Jan 2003 17:49:36 +0100 From: phk@freebsd.org To: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> Cc: current@freebsd.org Subject: Re: buildworld trouble: multiple struct dos_partition. Message-ID: <26833.1041612576@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 04 Jan 2003 01:13:05 %2B0900." <20030104.011305.74720364.nyan@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030104.011305.74720364.nyan@jp.FreeBSD.org>, Takahashi Yoshihiro writes: >In article <10926.1041590588@critter.freebsd.dk> >Poul-Henning Kamp <phk@freebsd.org> writes: > >> I think you need to either #ifdef something here (and there may be >> more some similar code in places like truss or the debugger) or >> alternatively rename the structure to "pc98_partition" or similar. > >I think that the name "dos_partition" is not suitable for both i386 >and pc98. I wonder what does "dos" mean here. For example, it should >be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98, >respectively. You are correct in principle. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?26833.1041612576>