Date: Sun, 06 Jul 2008 08:50:21 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> Cc: marcel@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 144741 for review Message-ID: <EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com> In-Reply-To: <20080706.110943.226722229.nyan@jp.FreeBSD.org> References: <200807051943.m65JhHZ6066371@repoman.freebsd.org> <20080706.110943.226722229.nyan@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 5, 2008, at 7:09 PM, Takahashi Yoshihiro wrote:
> In article <200807051943.m65JhHZ6066371@repoman.freebsd.org>
> Marcel Moolenaar <marcel@freebsd.org> writes:
>
>> static struct isa_pnp_id isa_i8251_ids[] = {
>> {0x0100e4a5, "RSA-98III"},
>> {0}
>> };
>
>> /* Probe PnP _and_ non-PnP i8251 here. */
>> if (ISA_PNP_PROBE(parent, dev, isa_i8251_ids) != ENXIO) {
>> sc->sc_class = &uart_i8251_class;
>> return (uart_bus_probe(dev, 0, 0, 0, 0));
>> }
>
> These are wrong. RSA98-III is based on ns8250 and has extended FIFO
> buffer. So I think that the uart_rsa_class should be added.
Oh. In your patch you define it as i8251. I only refactored
the code. Also, the ns8250 class already supports extended
FIFOs, so we don't need a separate class for that. I'll
change it...
> FYI, RSA series are not for pc98 only.
> RSA-PCI (PCI) and RSA-DVII (ISA) exist but not supported yet.
Ok, good to know. With the refactored code there's maximum
sharing, so UART will support them on other platforms as
well...
--
Marcel Moolenaar
xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EF89C58B-6C77-4738-8A77-44BD3B655ED5>