Date: Sat, 5 Jun 2010 14:55:22 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Julien Laffaye <jlaffaye@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 179200 for review Message-ID: <AANLkTil7IHlu88CO6kAJsZapMOEYMvka7kh5Ykf5JnDh@mail.gmail.com> In-Reply-To: <201006050617.o556HA8L019323@repoman.freebsd.org> References: <201006050617.o556HA8L019323@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 4, 2010 at 11:17 PM, Julien Laffaye <jlaffaye@freebsd.org> wrot= e: > http://p4web.freebsd.org/@@179200?ac=3D10 > > Change 179200 by jlaffaye@jlaffaye-chulak on 2010/06/05 06:16:29 > > =A0 =A0 =A0 =A0Changed the prototype of unpack_to_buffer() > =A0 =A0 =A0 =A0It is more useful now as we know the size of the buffer. > > Affected files ... > > .. //depot/projects/soc2010/pkg_complete/lib/libpkg/file.c#4 edit > .. //depot/projects/soc2010/pkg_complete/lib/libpkg/pkg.h#5 edit > > Differences ... > > =3D=3D=3D=3D //depot/projects/soc2010/pkg_complete/lib/libpkg/file.c#4 (t= ext+ko) =3D=3D=3D=3D > > @@ -335,20 +335,18 @@ > =A0* Unpack a single file, denoted by file, to a buffer. It proceeds to r= ead it > =A0* into the buffer which will need to be freed by the user at a later d= ate. > =A0* > - * Returns an address to a buffer with the contents of *file if successf= ul, or > - * returns NULL on failure. > + * Returns the size of the buffer if successful, or returns 0 on failure=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTil7IHlu88CO6kAJsZapMOEYMvka7kh5Ykf5JnDh>