Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Feb 2013 19:16:40 -0600
From:      Bryan Venteicher <bryanv@freebsd.org>
To:        Bryan Venteicher <bryanv@freebsd.org>
Cc:        svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r246307 - projects/virtio/sys/dev/virtio/block
Message-ID:  <CAGaYwLdESVGOPJn6ZvhS9mtWE=xnyoSEbyLUTOhGRN4iHkJESA@mail.gmail.com>
In-Reply-To: <201302032335.r13NZsYb088216@svn.freebsd.org>
References:  <201302032335.r13NZsYb088216@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 3, 2013 at 5:35 PM, Bryan Venteicher <bryanv@freebsd.org> wrote:
> Author: bryanv
> Date: Sun Feb  3 23:35:53 2013
> New Revision: 246307
> URL: http://svnweb.freebsd.org/changeset/base/246307
>
> Log:
>   virtio_blk: Correct stripe offset calculation
>
>   Pointed out by:       max

Oops, should be:

Pointed out by: mav

>   Approved by:  grehan (implicit)
>
> Modified:
>   projects/virtio/sys/dev/virtio/block/virtio_blk.c
>
> Modified: projects/virtio/sys/dev/virtio/block/virtio_blk.c
> ==============================================================================
> --- projects/virtio/sys/dev/virtio/block/virtio_blk.c   Sun Feb  3 23:35:05 2013        (r246306)
> +++ projects/virtio/sys/dev/virtio/block/virtio_blk.c   Sun Feb  3 23:35:53 2013        (r246307)
> @@ -725,8 +725,9 @@ vtblk_alloc_disk(struct vtblk_softc *sc,
>         if (virtio_with_feature(dev, VIRTIO_BLK_F_TOPOLOGY)) {
>                 dp->d_stripesize = dp->d_sectorsize *
>                     (1 << blkcfg->topology.physical_block_exp);
> -               dp->d_stripeoffset = dp->d_sectorsize *
> -                   blkcfg->topology.alignment_offset;
> +               dp->d_stripeoffset = (dp->d_stripesize -
> +                   blkcfg->topology.alignment_offset * dp->d_sectorsize) %
> +                   dp->d_stripesize;
>         }
>
>         if (vtblk_write_cache_enabled(sc, blkcfg) != 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGaYwLdESVGOPJn6ZvhS9mtWE=xnyoSEbyLUTOhGRN4iHkJESA>