Date: Thu, 07 Nov 2002 11:33:49 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Hidetoshi Shimokawa <simokawa@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/nge if_nge.c if_ngereg.h Message-ID: <ybsu1iuhzw2.wl@ett.sat.t.u-tokyo.ac.jp> In-Reply-To: <2604.1036598903@critter.freebsd.dk> References: <200211061550.gA6FoWQj062987@repoman.freebsd.org> <2604.1036598903@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
At Wed, 06 Nov 2002 17:08:23 +0100, Poul-Henning Kamp wrote: > > In message <200211061550.gA6FoWQj062987@repoman.freebsd.org>, Hidetoshi Shimoka > wa writes: > >simokawa 2002/11/06 07:50:32 PST > > > > Modified files: > > sys/dev/nge if_nge.c if_ngereg.h > > Log: > > Add support for DEVICE_POLLING. > > > > PR: kern/44772 > > Submitted by: Takashi Oono <takashi@yha.att.ne.jp> > > MFC after: 1 week > > > > Revision Changes Path > > 1.36 +76 -0 src/sys/dev/nge/if_nge.c > > 1.8 +3 -0 src/sys/dev/nge/if_ngereg.h > > Hang on for a second: > > This chip supports interrupt pacing so I would like to see > some documentation for an improvement from DEVICE_POLLING over > tuning the interrupt pacing in the chip, before we even think > about MFC, much less let this commit stay in the tree. I think interrupt pacing usually does good job too. But still, I think there could be some cases device polling does better job (ex. multiple busy NICs.) and it's a good thing to give a option to users. > What tests have been run ? > What are the numbers ? (and please, include a standard deviation!) I don't have any numbers by myself. I'm asking for the original author whether he has. /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ybsu1iuhzw2.wl>