Date: Thu, 08 Apr 2010 15:16:46 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nwhitehorn@FreeBSD.org Cc: jmallett@FreeBSD.org, src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r206392 - user/jmallett/octeon/sys/mips/mips Message-ID: <20100408.151646.884721755803198764.imp@bsdimp.com> In-Reply-To: <4BBDE4A5.8090604@freebsd.org> References: <201004080648.o386mKnr042060@svn.freebsd.org> <4BBDE4A5.8090604@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4BBDE4A5.8090604@freebsd.org> Nathan Whitehorn <nwhitehorn@FreeBSD.org> writes: : On 04/08/10 01:48, Juli Mallett wrote: : > Author: jmallett : > Date: Thu Apr 8 06:48:20 2010 : > New Revision: 206392 : > URL: http://svn.freebsd.org/changeset/base/206392 : > : > Log: : > Hide quad syscall calling convention behind __mips_o32. : > : > Modified: : > user/jmallett/octeon/sys/mips/mips/vm_machdep.c : > : > Modified: user/jmallett/octeon/sys/mips/mips/vm_machdep.c : > ============================================================================== : > --- user/jmallett/octeon/sys/mips/mips/vm_machdep.c Thu Apr 8 06:42:19 : > --- 2010 (r206391) : > +++ user/jmallett/octeon/sys/mips/mips/vm_machdep.c Thu Apr 8 06:48:20 : > 2010 (r206392) : > @@ -265,19 +265,29 @@ cpu_set_syscall_retval(struct thread *td : > { : > struct trapframe *locr0 = td->td_frame; : > unsigned int code; : > +#if defined(__mips_o32) : > int quad_syscall; : > +#endif : > : What about 32-bit O32 compatibility? For PPC64, I wrapped this kind of : code in if (p->p_sysent->sv_flags & SV_ILP32). Right now I don't think we support running binaries that are a different ABI than the kernel ABI. Long term, we'll need to do that. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100408.151646.884721755803198764.imp>