Date: Thu, 27 Feb 1997 20:52:48 -0500 (EST) From: Chuck Robey <chuckr@glue.umd.edu> To: Bill Fenner <fenner@parc.xerox.com> Cc: FreeBSD current <freebsd-current@freefall.freebsd.org> Subject: Re: fixing fsck Message-ID: <Pine.OSF.3.95q.970227205101.28151B-100000@uplink.eng.umd.edu> In-Reply-To: <97Feb27.173846pst.177476@crevenia.parc.xerox.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Feb 1997, Bill Fenner wrote: > Chuck Robey <chuckr@glue.umd.edu> wrote: > >In dinode.h, all the time related fields, which used to be > >timespec structs (members tv_sec and tv_usec) are now int32_t, which > >doesn't have any logical connection to their time-related usage at all. > >I can't understand the reasoning behind this change. > > If you look carefully at the diffs, the old > > struct timespec di_atime; > > changed to > > int32_t di_atime; > int32_t di_atimensec; > > which makes it relatively clear what happened, especially if you look > at the byte offsets in the comments. di_atime.ts_sec became di_atime, > and di_atime.ts_nsec became di_atimensec. The diff also describes the > reason for this change: > > + * This structure defines the on-disk format of a dinode. Since > + * this structure describes an on-disk structure, all its fields > + * are defined by types with precise widths. Didn't see that. OK, I guess, I can go back to fixing it (unless someone beats me to it). It wasn't a matter of mechanics, it was understanding what was going on, which I now do. Thanks. > > > Bill > ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@eng.umd.edu | communications topic, C programming, and Unix. 9120 Edmonston Ct #302 | Greenbelt, MD 20770 | I run Journey2 and picnic, both FreeBSD (301) 220-2114 | version 3.0 current -- and great FUN! ----------------------------+-----------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.OSF.3.95q.970227205101.28151B-100000>