Date: Tue, 23 Jan 2001 20:06:44 -0500 From: "Bosko Milekic" <bmilekic@technokratis.com> To: "John Baldwin" <jhb@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern kern_malloc.c Message-ID: <025601c085a1$eb367f20$1f90c918@jehovah> References: <200101240036.f0O0a4114273@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin: > jhb 2001/01/23 16:36:04 PST > > Modified files: > sys/kern kern_malloc.c > Log: > Don't grab Giant when calling kmem_alloc/kmem_free as this is just > encouraging other people to follow the same practice. If this is going > to be done, then it should be done inside of those two functions instead. > > Revision Changes Path > 1.79 +1 -5 src/sys/kern/kern_malloc.c We should do this and add the proper (temporary) assertions/invariants/witness checks in there, as soon as possible, then. Several portions of code using the kmem_*() code are doing this right now, as you probably now, and we're just (needlessly) repeating the assertions. I don't mind doing it later this week, when I'm done with what I'm presently working with. -Bosko. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?025601c085a1$eb367f20$1f90c918>