Date: Tue, 10 Feb 2015 14:32:44 -0700 From: Ian Lepore <ian@freebsd.org> To: Michael Gmelin <grembo@freebsd.org> Cc: freebsd-current Current <freebsd-current@freebsd.org>, Peter Wemm <peter@wemm.org>, Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: nagios vs w/uptime Message-ID: <1423603964.80968.28.camel@freebsd.org> In-Reply-To: <E36EA56E-3B9E-4C40-B984-E7BE97F0175E@freebsd.org> References: <54DA617A.4090309@wemm.org> <A3904FE0-2D03-4290-B29E-395E8C6F6F96@xcllnt.net> <4A76A371-B573-4E62-BE78-94944963FFD0@freebsd.org> <E36EA56E-3B9E-4C40-B984-E7BE97F0175E@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2015-02-10 at 22:24 +0100, Michael Gmelin wrote: > > > > On 10 Feb 2015, at 22:17, Michael Gmelin <grembo@freebsd.org> wrote: > > > > > > > > > >> On 10 Feb 2015, at 21:13, Marcel Moolenaar <marcel@xcllnt.net> wrote: > >> > >> [Moving to current@] > >> > >>> On Feb 10, 2015, at 11:52 AM, Peter Wemm <peter@wemm.org> wrote: > >>> > >>> Surprises: > >>> * nagios doesn't like w / uptime anymore. libxo perhaps? > >> > >> Seems most likely, although I havenąt seen any differences in output > >> in my (admittedly limited) testing. > >> > >> In what way does Nagios not like w/uptime? > >> Any concrete errors, output or misbehavior? > >> Ideally: can you reproduce the problem? > > > > > > Just compared 10.1 to current, unmodified output looks the same, but pipelines don't work properly: > > > > 10.1: > > # uptime | wc > > 1 12 68 > > > > Current: > > # uptime | wc > > 0 0 0 > > > > # uptime | cat > > # uptime > > 10:16PM up 9 mins... > > > > Adding xo_finish() to w.c line 268 just right before exit(0); fixes that issue (I don't know libxo well enough to say if this is the proper fix or just a workaround, but it seems logical to me). > I wonder if that implies that any non-normal exit from a program that has been xo'd will result in the loss of output that would not have been lost before the xo changes? That could lead to all kinds of subtle failures of existing scripts and apps. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1423603964.80968.28.camel>