Date: Tue, 24 Nov 1998 13:06:56 -0800 (PST) From: Archie Cobbs <archie@whistle.com> To: dillon@apollo.backplane.com (Matthew Dillon) Cc: bde@zeta.org.au, freebsd-current@FreeBSD.ORG, grog@lemis.com, rnordier@nordier.com Subject: Re: snprintf() in the kernel Message-ID: <199811242106.NAA05958@bubba.whistle.com> In-Reply-To: <199811240900.BAA13142@apollo.backplane.com> from Matthew Dillon at "Nov 24, 98 01:00:15 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon writes: > I have a suggestion, why not split the problem up... commit the > kernel snprintf() subroutine first, then put up a small subset of the > snprintf() changes up for review and commit those on a fast track. i.e. > get some of the more obvious sprintf() -> snprintf() fixes in and proven. That makes sense.. especially so people can start using snprintf() if they want, instead of waiting for this discussion to finish.. :-) > Personally, I think we need to move to length-limited copies for all > string operations. The code may be correct as is, and it may seem obvious > to the people who wrote it, but FreeBSD is a collective effort and the > more mistakes we can prevent in the future without compromising code > effectiveness the better. Me too. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811242106.NAA05958>