Date: Wed, 18 Jul 2001 11:00:51 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Alexey Zelkin <phantom@FreeBSD.org.ua> Cc: audit@FreeBSD.org, Dag-Erling Smorgrav <des@ofug.org> Subject: Re: whois(1) changes Message-ID: <20010718110051.A52720@coffee.q9media.com> In-Reply-To: <20010718154425.A65945@phantom.cris.net>; from phantom@FreeBSD.org.ua on Wed, Jul 18, 2001 at 03:44:25PM %2B0300 References: <20010717214524.A51455@coffee.q9media.com> <20010718154425.A65945@phantom.cris.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 18, 2001 at 03:44:25PM +0300, Alexey Zelkin wrote: > On Tue, Jul 17, 2001 at 09:45:24PM -0400, Mike Barcroft wrote: > > whois.20010717.patch > > > > o Reintegrate part of phantom's patch which adds gethostinfo(). > > o Create a wrapper for asprintf(3) which checks for failure. > > o Tested on i386, alpha. > > [patch skiped] > > 1. isdigit()'s argument should be explicitly casted to 'unsigned char' per > ache's guidelines. Can you explain this in more detail? To my understanding, one only does this when using setlocale(3) and friends. > 2. I think it's time to go thru include files and cleanup it. As far as I can tell, all the current includes are required. Do you see any includes that can safely be removed? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010718110051.A52720>