Date: Fri, 17 Aug 2001 14:09:12 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Maxim Sobolev <sobomax@freebsd.org> Cc: current@freebsd.org Subject: Re: 4-STABLE-->5-CURRENT upgrade path is b0rken in libform [patch] Message-ID: <20010817140912.B88339@sunbay.com> In-Reply-To: <200108171021.f7HALxG16809@vega.vega.com>; from sobomax@freebsd.org on Fri, Aug 17, 2001 at 01:21:59PM %2B0300 References: <200108171021.f7HALxG16809@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 17, 2001 at 01:21:59PM +0300, Maxim Sobolev wrote:
> Hi,
>
> Currently 4-STABLE --> 5-CURRENT upgrade path is broken in libform
> because it uses older curses.h header from the host system, which
> misses some macros necessary. Attached patch is expected to fix the
> problem, please review it and let me know if it is OK to commit it.
>
Are you sure?
1. We currently run `buildworld' with -nostdinc, so /usr/include
(unless explicitly specified by CFLAGS) headers aren't used.
2. `make includes' is executed first, before `make libraries' in
`buildworld', and the former installs the correct curses.h
into /usr/obj/usr/src/i386/usr/include.
3. I can't reproduce your problem on my dual 4.4-PREPELEASE and
5.0-CURRENT box.
I can only imagine this scenario if you try to execure `make all'
from src/lib/libform manually.
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/lib/libform/Makefile,v
> retrieving revision 1.6
> diff -d -u -r1.6 Makefile
> --- Makefile 2001/03/27 17:27:01 1.6
> +++ Makefile 2001/08/17 10:16:24
> @@ -21,8 +21,9 @@
> INCS= ${NCURSES}/form/form.h
>
> CLEANFILES+= ncurses_def.h
> -CFLAGS+= -I. -I${.CURDIR}/../libncurses -I${NCURSES}/form -I${NCURSES}/menu \
> - -I${NCURSES}/include -Wall -DNDEBUG -DHAVE_CONFIG_H
> +CFLAGS+= -I. -I${.CURDIR}/../libncurses -I${.OBJDIR}/../libncurses \
> + -I${NCURSES}/form -I${NCURSES}/menu -I${NCURSES}/include \
> + -Wall -DNDEBUG -DHAVE_CONFIG_H
>
> ncurses_def.h: MKncurses_def.sh ncurses_defs
> AWK=${AWK} sh ${NCURSES}/include/MKncurses_def.sh \
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010817140912.B88339>